Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging completed milestones for 1.1 #14

Merged
merged 79 commits into from
Jan 9, 2020
Merged

Merging completed milestones for 1.1 #14

merged 79 commits into from
Jan 9, 2020

Conversation

taylorb-syd
Copy link
Contributor

Implements:
#1 #5 #11

taylorb-syd and others added 30 commits January 6, 2018 15:19
@taylorb-syd
First Draft of Possible Redacing Logic and Squash Logic
8bc92c1
@taylorb-syd
added RedactMode to init and updated docs for redaction
e0aa3fd
@taylorb-syd
changed scope of "redactMode" and "redactProperties"
fbdf65e
@taylorb-syd
added redactResponseURL property
b1e736e
@taylorb-syd
added NoEcho to squashed responses
052970f
@taylorb-syd
changed boolean to true string literal in NoEcho
d04d285
@taylorb-syd
fixed typo in comment
3194291
@taylorb-syd
Data is an optional field, so excluding it rather than including a pl…
21c579e 
…aceholder
@NightKhaos
changed redact properties to regex and added timeout logic
7cc3663
@NightKhaos
added docs about SIGALRM in timeout
7a2f223
@NightKhaos
documentation update for Note on Signals
c891422
@NightKhaos
require two arguements for signal handler function
9e74b0e
@NightKhaos
added notes re timeout handler
2ed07e8
@NightKhaos
wrote timeout logic to chain invoke
340fd3a
@NightKhaos
refined redaction logic
fdc0cbf
@NightKhaos
fixed __init__ ordering in StandaloneRedactionConfig
10a6111
@NightKhaos
changed uuid to str() rather than .hex, added some extra logging
80c4d9b
@NightKhaos
added note for timeouts
e1da8fe
@NightKhaos
logging revisions and logging notes in README
cdea591
@NightKhaos
minor README fix
04b3b49
@NightKhaos
removed current testing examples
a3b4b4a
@NightKhaos
documentation updates, requirements.txt updates, restricting to Pytho…
a9a1e7d 
…n 3.6 only, other minor fixes
@NightKhaos
started adding tests
f911065
@NightKhaos
Changed git ignore.
434d377
@NightKhaos
Formatting improvements
c421391
@NightKhaos
Realised chained invoke could result in two executions of CR. Fixed.
5ed0846
@NightKhaos
Documentation updates and fixing an edge case with chained invokes
ea31d31
@NightKhaos
Documentation Syntax Highlighting
f50ee89
@NightKhaos
Added blurb about how to create a Lambda Zip
3d21ed0
@NightKhaos
Blurb says INFO, should use INFO in example.
b85a0eb
NightKhaos and others added 23 commits January 26, 2019 12:38
@NightKhaos @taylorb-syd
documentation updates, requirements.txt updates, restricting to Pytho…
7e5d039 
…n 3.6 only, other minor fixes
@NightKhaos @taylorb-syd
started adding tests
774124d
@NightKhaos @taylorb-syd
Changed git ignore.
e1987b5
@NightKhaos @taylorb-syd
Formatting improvements
c8fc571
@NightKhaos @taylorb-syd
Realised chained invoke could result in two executions of CR. Fixed.
eef695f
@NightKhaos @taylorb-syd
Documentation updates and fixing an edge case with chained invokes
daeb5f9
@NightKhaos @taylorb-syd
Documentation Syntax Highlighting
a3b40d1
@NightKhaos @taylorb-syd
Blurb says INFO, should use INFO in example.
f519069
@NightKhaos @taylorb-syd
Completed Redaction Tests, Starting Response Tests
3b3d8be
@taylorb-syd
started testing class
d3235e0
@taylorb-syd
fixed merge commit
3ce450f
@taylorb-syd
Formatted Documentation, added type hints, added is_valid_event function
424d983
@taylorb-syd
Requests migration and testing logic (#13)
b3c6168 
* Moved to requests instead of botocore.vendored requests and started implementing response testing

* typo in docs

Implements #11
@taylorb-syd
moved back to defined dependecies, wrote makefile and started writing…
36074a2 
… functional testing templates
@taylorb-syd
changed makefile to use python3 -m pip instead of pip
87947e3
@taylorb-syd
performing testing and debugging of chained invoke logic
d357b3a
@taylorb-syd
removed version blurb as 2.7 is deprecrated
742bf7b
@taylorb-syd
added bit about Lambda Layers
32616d2
@taylorb-syd
tested using 3.8
b05b74e
@taylorb-syd
further doc improvements
01ac9e8
@taylorb-syd
python3 -m pip instead of pip3
aff7ae5
@taylorb-syd
typo there/three
e2f7544
@taylorb-syd
tested redaction logic and fixed bugs related, downgraded to python3.…
f4838ea 
…7 for testing due to jmespath bug
NightKhaos
NightKhaos approved these changes Jan 9, 2020
View reviewed changes
Copy link

@NightKhaos NightKhaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylorb-syd taylorb-syd merged commit 5b2ae14 into stable Jan 9, 2020
@taylorb-syd taylorb-syd deleted the master branch January 9, 2020 06:06
@taylorb-syd taylorb-syd self-assigned this Jan 9, 2020
@taylorb-syd taylorb-syd added this to the 1.1 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightKhaos NightKhaos NightKhaos approved these changes

Assignees

@taylorb-syd taylorb-syd

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylorb-syd @NightKhaos