Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable spark-operator prometheus metrics #737

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

alanty
Copy link
Contributor

@alanty alanty commented Jan 31, 2025

What does this PR do?

Enables the prometheus PodMonitor creation in the spark-operator helm chart and updates the prometheus config to pick up monitors across namespaces (kube-prometheus-stack, is the default)

Motivation

as we continue benchmarks/testing having visibility into the operator performance will help us understand the performance

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@alanty alanty changed the title Enable spark-operator prometheus metrics feat: Enable spark-operator prometheus metrics Jan 31, 2025
@vara-bonthu vara-bonthu merged commit c573036 into awslabs:main Jan 31, 2025
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants