Convert codebase to scala 2.13 #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samidalouche
commented
Aug 9, 2023
| @@ -81,26 +81,26 @@ class MetricsRepositoryMultipleResultsLoaderTest extends AnyWordSpec with Matche | |||
| val analysisResultsAsJson = repository.load() | |||
| .getSuccessMetricsAsJson() | |||
|
|
|||
| val expected = | |||
| s"""[{"entity":"Dataset","instance":"*","name":"Size","value":4.0, | |||
| val expected = | |||
There was a problem hiding this comment.
scala 2.13 collections break the previous ordering of elements
samidalouche
commented
Aug 9, 2023
| |"instance":"att1,att2","name":"MutualInformation","value":0.5623351446188083}, | ||
| |{"dataset_date":1507975810,"entity":"Dataset","region":"EU", | ||
| |"instance":"*","name":"Size","value":4.0}, | ||
| |"instance":"att1","name":"MaxLength","value":1.0}, |
There was a problem hiding this comment.
scala 2.13 collections break the previous ordering of elements
samidalouche
commented
Aug 9, 2023
| """[{"entity":"Column","instance":"att1","name":"Completeness","value":1.0}, | ||
| |{"entity":"Multicolumn","instance":"att1,att2", | ||
| |"name":"Uniqueness","value":0.25}]""" | ||
| val expectedJson = |
There was a problem hiding this comment.
scala 2.13 collections break the previous ordering of elements
samidalouche
commented
Aug 9, 2023
| |{"entity":"Column","instance":"att1","name":"Histogram.ratio.b","value":0.25} | ||
| |]""" | ||
| .stripMargin.replaceAll("\n", "") | ||
| val expectedJson = |
There was a problem hiding this comment.
scala 2.13 collections break the previous ordering of elements
samidalouche
commented
Aug 9, 2023
| @@ -79,12 +79,13 @@ class VerificationResultTest extends WordSpec with Matchers with SparkContextSpe | |||
| val successMetricsResultsJson = VerificationResult.successMetricsAsJson(results) | |||
|
|
|||
| val expectedJson = | |||
| """[{"entity":"Column","instance":"item","name":"Distinctness","value":1.0}, | |||
There was a problem hiding this comment.
scala 2.13 collections break the previous ordering of elements
samidalouche
commented
Aug 9, 2023
| """[{"entity":"Column","instance":"att1","name":"Completeness","value":1.0}, | ||
| |{"entity":"Multicolumn","instance":"att1,att2", | ||
| |"name":"Uniqueness","value":0.25}]""" | ||
| """[ |
There was a problem hiding this comment.
scala 2.13 collections break the previous ordering of elements
|
I am interested in this PR too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None, but happy to create one if it helps.
Description of changes:
Is scala 2.13 on your roadmap? Are you considering either providing scala-2.13-only builds, or cross-compiling against 2.12 and 2.13?
If this is something you consider, then I hope this PR will help you.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.