Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport breeze version upgrade to spark 3.4 #581

Merged

Conversation

zeotuan
Copy link
Contributor

@zeotuan zeotuan commented Sep 11, 2024

In #545, we were expecting to see breeze 2.1.0 release with spark 3.4+ but Deequ 2.0.7-spark3.4 doesn't seem to include this changes even though the release note mentioned it https://github.com/awslabs/deequ/releases/tag/2.0.7.
Can we backport this change and release it for Deequ 2.0.7-spark3.4 or maybe Deequ 2.0.8?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zeotuan
Copy link
Contributor Author

zeotuan commented Sep 12, 2024

This will also solve the issue mentioned here awslabs/python-deequ#192 (comment)

@zeotuan
Copy link
Contributor Author

zeotuan commented Sep 16, 2024

Hi @rdsharma26, @mentekid please help review this one.

pom.xml Outdated
@@ -327,6 +327,13 @@
</plugin>
</plugins>
</build>
<repositories>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is the addition of repositories necessary for this change? Asking cause I don't see it in #545

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unrelated change

@eycho-am eycho-am changed the base branch from release/2.0.7-spark-3.4 to release/2.0.8-spark-3.4 October 9, 2024 18:33
@eycho-am eycho-am merged commit eb291ce into awslabs:release/2.0.8-spark-3.4 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants