update: argo-cd to v2.12.3
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @meetreks I started to review this and found that when the Helm chart went to version 6.0.0 they completed redesigned Ingress. See: https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/README.md#600. So when I tested with an Ingress like Let me know if you want to update this or if you want me to fix it. Thanks. |
|
@meetreks checking in on the PR. Do you still have cycles to update the Ingress settings that changed with the new version? |
aaroniscode
force-pushed
the
feature/argo-cd
branch
from
9678350 to
f849b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.