Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Karpenter 1.0 installation fails when using Bottlerocket #251

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

JoeNorth
Copy link
Contributor

Issue #249

Description of changes:
Adds lookups for Bottlerocket AMIs so that the EC2NodeClass is created correctly.

$ ./eksdemo install karpenter -c main-lab -a Bottlerocket --dry-run

apiVersion: karpenter.k8s.aws/v1
kind: EC2NodeClass
metadata:
  name: default
spec:
  amiFamily: Bottlerocket
  role: KarpenterNodeRole-main-lab
  subnetSelectorTerms:
    - tags:
        Name: eksctl-main-lab-cluster/SubnetPrivate*
  securityGroupSelectorTerms:
    - tags:
        aws:eks:cluster-name: main-lab
  tags:
    eksdemo.io/version: v0.16.0-29-g43b91f2-dev
  amiSelectorTerms:
    - id: ami-09a54b713b931a469
    - id: ami-0b07fdee374ab4cf3

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@aaroniscode aaroniscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JoeNorth ! This is a great PR and thanks for fixing my spelling error! :)

@aaroniscode aaroniscode merged commit 2266e9d into awslabs:main Sep 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants