This repository has been archived by the owner on May 6, 2024. It is now read-only.
Use dep for dependencies #25
Merged
+1,180
−1,023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make setup and predictable builds easier for contributors by locking to a set of dependencies. Some of the dependencies have been locked to specific commits on master in order to accomodate projects that do not ship releases often such as cobra and gomock (see spf13/cobra#259 for details). - Change mockgen commands to use a -source flag to explicitly point to the files in vendor for generating mocks. This, for some reason, fixes a bug in gomock whereby it uses the vendor path as the import path which breaks some dependencies. See golang/mock#28 for more details.
|
Addresses #21. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make setup and predictable builds easier for contributors by locking to
a set of dependencies. Some of the dependencies have been locked to
specific commits on master in order to accomodate projects that do not
ship releases often such as cobra and gomock (see
spf13/cobra#259 for details).
Change mockgen commands to use a -source flag to explicitly point to
the files in vendor for generating mocks. This, for some reason, fixes
a bug in gomock whereby it uses the vendor path as the import path
which breaks some dependencies.
See support mocking vendored dependencies golang/mock#28 for more details.