This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: implement multi-tenancy and group export #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add tenantId attribute to Cognito user pool * feat: remove unneeded scope checks in authorizer (#347)
* chore: script generating patient compartment search params * feat: update Glue script for group export * Upload patient compartment jsons to S3
ssvegaraju
approved these changes
Aug 18, 2021
Yeah, I dismissed it as “used in tests” |
rsmayda
reviewed
Aug 18, 2021
rsmayda
reviewed
Aug 18, 2021
Comment on lines
+31
to
+34
| }, | ||
| { | ||
| 'Name': 'custom:tenantId', | ||
| 'Value': 'tenant1' |
There was a problem hiding this comment.
When provisioning to a non multi tenant solution will this cause any issues? I don't think so
There was a problem hiding this comment.
It won't. It'll be an unused attribute of the users
rsmayda
approved these changes
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is it. This is the final merge of the feat-multitenancy branch into mainline
All changes have been reviewed before in separate PRs except for the last 2:
This updates the gh workflow to also run all tests in a separate multi-tenant environment. It uses the GH matrix startegy to run the same job with different parameters.
A successful run (except for the merge job that was expected to fail) from my fork: https://github.com/carvantes/fhir-works-on-aws-deployment/actions/runs/1141190132
Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.