Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

test: integration test for chained parameters #500

Merged
merged 11 commits into from
Nov 3, 2021
Merged

Conversation

Bingjiling
Copy link
Contributor

@Bingjiling Bingjiling commented Oct 26, 2021

Issue #, if available:

Description of changes:

  • Add integration test for chained parameters in search

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Bingjiling Bingjiling changed the base branch from mainline to develop October 26, 2021 21:57
integration-tests/search.test.ts Outdated Show resolved Hide resolved
integration-tests/search.test.ts Outdated Show resolved Hide resolved
integration-tests/utils.ts Show resolved Hide resolved
@Bingjiling Bingjiling requested a review from rsmayda October 29, 2021 02:22
rsmayda
rsmayda previously requested changes Nov 1, 2021
Copy link
Contributor

@rsmayda rsmayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Blocking until package.json is updated with new Search version

@github-actions github-actions bot added size/xl and removed size/m labels Nov 2, 2021
@github-actions github-actions bot added size/m and removed size/xl labels Nov 2, 2021
@Bingjiling Bingjiling dismissed rsmayda’s stale review November 3, 2021 14:29

Search version updated

@Bingjiling Bingjiling merged commit f122394 into develop Nov 3, 2021
@Bingjiling Bingjiling deleted the chained-parameter branch November 3, 2021 14:30
Bingjiling added a commit that referenced this pull request Nov 4, 2021
* chore: ES logging, SQS encryption (#504)

* test: integration test for chained parameters (#500)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants