-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(opensearchserverless): refactor cdk construct #797
Conversation
Thanks @erdemayyildiz ! Could you please run a full build locally, it seems the build was failing because of a mutation |
Thanks @erdemayyildiz ! Could you please provide some information on how you tested those changes ? It would be great to deploy this with the bedrock agent sample from the constructs |
Signed-off-by: Alain Krok <alkrok@amazon.com>
hi @krokoko yes i have deployed bedrock-agent to test my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, only issue are the calls to generatePhysicalNamev2 which require an update
@erdemayyildiz pushed some changes with:
|
Hey @krokoko great, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #737, #271
refactor for opensearchserverless constructs that follows best practices https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md
created interface for VectorCollection extended from IResource - https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#construct-interface
created VectorCollectionBase implements IVectorCollection - https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#abstract-base
created default metrics - https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#metrics
created import methods
fromCollectionName
,fromCollectionAttributes
- https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#importsdeveloped additional test cases for refactored lines.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.