Exclude empty provider output. Closes #34 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelwittig Would you be able to review this? |
majormoses
reviewed
Nov 1, 2016
| echo "$(export IFS=$'\n\t '; $cmd)" | ||
| local result="$(export IFS=$'\n\t '; $cmd)" | ||
| # Do not add empty lines from providers as that would match everything. | ||
| if [ "${result}" != "" ]; then |
There was a problem hiding this comment.
any reason to not use the built in bash checks?
if [[ -n "${result}" ]]; thenThere was a problem hiding this comment.
No reason. I'll update to use that instead. Edit: updated to use -n.
mtdowling
force-pushed
the
fix-empty-providers
branch
from
3239370
to
4b5f8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.