Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store GluonTS Version with stored Model #278

Closed
jaheba opened this issue Sep 2, 2019 · 2 comments
Closed

Store GluonTS Version with stored Model #278

jaheba opened this issue Sep 2, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.4

Comments

@jaheba
Copy link
Contributor

jaheba commented Sep 2, 2019

When we serialise a model, we should also store the current GluonTS version with it.

That way we can track backwards compatible or breaking changes.
@jaheba jaheba added the enhancement New feature or request label Sep 2, 2019
@jaheba jaheba added this to the v0.4 milestone Sep 2, 2019
@lostella lostella added the good first issue Good for newcomers label Sep 11, 2019
@timoschowski timoschowski mentioned this issue Oct 12, 2019
Merged
@timoschowski
Copy link
Contributor

PR #388 is a rather minimal answer to the issue. I was thinking whether it makes sense to check it during deserialization, but this didn't lead anywhere.

@jaheba
Copy link
Contributor Author

jaheba commented Oct 12, 2019

As a follow-up, we should also read-out the version when we deserialise the model and do some checks on the version.

timoschowski added a commit that referenced this issue Oct 12, 2019
@timoschowski
address issue #278 (#388)
db91331 
* address issue #278

* address comments

* make sure code formatting is on-board
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
3 participants
@jaheba @lostella @timoschowski