Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing case with only time features and yearly freq #1002

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

dcmaddix
Copy link
Contributor

@dcmaddix dcmaddix commented Aug 24, 2020

  • Fixed MQ-CNN with yearly freq and only time as the dynamic feature
  • In this case no dynamic features are created because the time feature is empty for Y freq and dynamic_feat is None
  • Updated to create the dummy zero feature in this case
  • Added test_mqcnn_covariate_smoke_test to use freq = Y to test this. Before would fail with add_time_feature = True, add_age_feature = False and use_feat_dyanmic_real = True

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dcmaddix dcmaddix merged commit 25e70ad into awslabs:master Aug 24, 2020
@dcmaddix dcmaddix deleted the mqcnn-freq-yearly branch August 24, 2020 20:08
kashif pushed a commit to kashif/gluon-ts that referenced this pull request Oct 10, 2020
Co-authored-by: Danielle Robinson <dmmaddix@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants