Using pad_to_size function to remove duplicate code in pad_arrays #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
requested changes
Sep 22, 2020
There was a problem hiding this comment.
@dcmaddix it would be nice to keep the code that requires MXNet under the gluonts.mx subpackage, so that it's clear which imports path require MXNet being installed and which ones don't.
I guess pad_arrays could be part of gluonts.mx.utils?
yes, I moved it back to |
lostella
previously approved these changes
Sep 28, 2020
… of tests so that the flaky tests pass
lostella
approved these changes
Sep 29, 2020
kashif
pushed a commit
to kashif/gluon-ts
that referenced
this pull request
Oct 10, 2020
…slabs#1047) * Using pad_to_size function to remove deuplicate code in pad_arrays and moving to util * Removed test_pad_arrays_axis from test_variable_length * Moving pad_arrays back to mx.batchify since it uses mxnet * Added unused multi_processing test param back to have the same number of tests so that the flaky tests pass * Fixing black Co-authored-by: Danielle Robinson <dmmaddix@amazon.com> Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
pad_arraystoutil.pypad_to_sizefunction to remove duplicate code and return before callingnd.padif no padding is needed.get_datasettotestutil/dummy_datasetstest_pad_arrays_axistotest/util.pyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.