PyTorch Predictor #1051
Merged
PyTorch Predictor #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
previously requested changes
Sep 23, 2020
There was a problem hiding this comment.
Thanks for this! I have only a few comments inline for now.
For the notebook: before we can merge it you should make sure to clear all cells, so that the state of the notebook is not checked into the repo (this makes the file much more lightweight in general)
|
@PascalIversen one more comment: maybe it's better to split this into multiple PRs
I'm checking how quick this can be done, but it seems that if you reset the branch to master and only add files outside of Let me know if you have time for this, otherwise I can take care of 1, and rebase the current PR on top of that. |
This was referenced Sep 23, 2020
PascalIversen
force-pushed
the
pytorch_predictor_v2
branch
from
d2249d1
to
58ae3be
Compare
jaheba
reviewed
Sep 28, 2020
Co-authored-by: Jasper <jasper.b.schulz@googlemail.com>
Co-authored-by: Jasper <jasper.b.schulz@googlemail.com>
Co-authored-by: Jasper <jasper.b.schulz@googlemail.com>
jaheba
approved these changes
Sep 28, 2020
lostella
reviewed
Sep 28, 2020
lostella
approved these changes
Sep 28, 2020
kashif
pushed a commit
to kashif/gluon-ts
that referenced
this pull request
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
PyTorchPredictorclassgluonts.torch.support.util.copy_parametersfunctionbased on PR #1052
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.