Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added item_id to NPTS and Naive2 forecasts #1173

Merged

Conversation

kaijennissen
Copy link
Contributor

@kaijennissen kaijennissen commented Nov 26, 2020

Issue #, if available:
#1170

Description of changes:
added item_id argument to NPTSPredictor.predict_time_seriesand NPTS.predict,

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for spotting this! I think we can backport this to the 0.6.x branch, and have this part of the next bugfix release

@lostella lostella changed the title added item_it to npts.predict Added item_id to NPTS and Naive2 forecasts Nov 26, 2020
@lostella lostella merged commit fd6ed94 into awslabs:master Nov 26, 2020
Schmedu pushed a commit to Schmedu/gluon-ts that referenced this pull request Dec 1, 2020
* added item_it to npts.predict

* black

* added item_it to naive_2
@Schmedu Schmedu mentioned this pull request Dec 1, 2020
Schmedu added a commit that referenced this pull request Dec 1, 2020
* Added item_id to NPTS and Naive2 forecasts (#1173)
* fixes in dataset mutability (#1171)

Co-authored-by: kja <50238578+kaijennissen@users.noreply.github.com>
Co-authored-by: Konstantinos Benidis <benidisk@gmail.com>
kashif pushed a commit to kashif/gluon-ts that referenced this pull request Dec 15, 2020
* added item_it to npts.predict

* black

* added item_it to naive_2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants