Fix r_forecast wrapper to shift start date when truncating time series
#2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
pending v0.9.x backport
pending v0.10.x backport
|
Thanks @abdulfatir! I think we should probably also update this test to cover also non-default values of |
|
@lostella Updated test. |
lostella
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Thanks @abdulfatir! Looks good to me, it seems like tests for these models are not running in the GitHub workflows, but we will fix this separately.
lostella
changed the title
r_forecast wrapper to shift start date when truncating time series
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Aug 26, 2022
Merged
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Aug 26, 2022
Merged
lostella
pushed a commit
that referenced
this pull request
Aug 26, 2022
lostella
pushed a commit
that referenced
this pull request
Aug 26, 2022
lostella
removed
pending v0.9.x backport
pending v0.10.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixed the r_forecast wrapper to shift the start date of the time series accordingly when truncating the time series. Currently, it uses the the original start date even for the truncated time series which results in an incorrect forecast start date.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup