-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More operators for synthetic data generation #286
Conversation
Job PR-286/1 is complete. |
Stuff needs to be blacked |
Job PR-286/2 is complete. |
Looks like some code is outdated (maybe after a rebase?): ==================================== ERRORS ====================================
___________ ERROR collecting test/dataset/artificial/test_recipe.py ____________
ImportError while importing test module '/var/lib/jenkins/workspace/workspace/gluon-ts-cpu-py3/test/dataset/artificial/test_recipe.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/dataset/artificial/test_recipe.py:27: in <module>
from gluonts.dataset.artificial.recipe import (
E ImportError: cannot import name 'evaluate_recipe'
_____________ ERROR collecting test/model/test_models_synthetic.py _____________
test/model/test_models_synthetic.py:26: in <module>
dataset_info, train_ds, test_ds = default_synthetic()
src/gluonts/dataset/artificial/_base.py:779: in default_synthetic
generated = data.generate()
src/gluonts/dataset/artificial/_base.py:735: in generate
for x in full_length_data
src/gluonts/dataset/artificial/_base.py:735: in <listcomp>
for x in full_length_data
src/gluonts/dataset/artificial/_base.py:706: in trim_ts_item_front
item=x["item"],
E KeyError: 'item' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff needs to be fixed, see my comment above
a24d987
to
a724cef
Compare
Job PR-286/3 is complete. |
Job PR-286/4 is complete. |
Looks good. Black is still complaining about |
Job PR-286/5 is complete. |
Job PR-286/6 is complete. |
…m key as changed in the synthetic dataset classes in PR #286
…e ArtificalDataset in PR #286
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.