Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More operators for synthetic data generation #286

Merged
merged 5 commits into from
Sep 16, 2019

Conversation

jgasthaus
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link
Member

szha commented Sep 5, 2019

Job PR-286/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-286/1/index.html

@lostella
Copy link
Contributor

lostella commented Sep 5, 2019

Stuff needs to be blacked

@szha
Copy link
Member

szha commented Sep 6, 2019

Job PR-286/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-286/2/index.html

vafl
vafl previously approved these changes Sep 9, 2019
@lostella
Copy link
Contributor

lostella commented Sep 9, 2019

Looks like some code is outdated (maybe after a rebase?):

==================================== ERRORS ====================================
___________ ERROR collecting test/dataset/artificial/test_recipe.py ____________
ImportError while importing test module '/var/lib/jenkins/workspace/workspace/gluon-ts-cpu-py3/test/dataset/artificial/test_recipe.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/dataset/artificial/test_recipe.py:27: in <module>
    from gluonts.dataset.artificial.recipe import (
E   ImportError: cannot import name 'evaluate_recipe'
_____________ ERROR collecting test/model/test_models_synthetic.py _____________
test/model/test_models_synthetic.py:26: in <module>
    dataset_info, train_ds, test_ds = default_synthetic()
src/gluonts/dataset/artificial/_base.py:779: in default_synthetic
    generated = data.generate()
src/gluonts/dataset/artificial/_base.py:735: in generate
    for x in full_length_data
src/gluonts/dataset/artificial/_base.py:735: in <listcomp>
    for x in full_length_data
src/gluonts/dataset/artificial/_base.py:706: in trim_ts_item_front
    item=x["item"],
E   KeyError: 'item'

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff needs to be fixed, see my comment above

@szha
Copy link
Member

szha commented Sep 13, 2019

Job PR-286/3 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-286/3/index.html

@szha
Copy link
Member

szha commented Sep 16, 2019

Job PR-286/4 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-286/4/index.html

@vafl
Copy link
Contributor

vafl commented Sep 16, 2019

Looks good. Black is still complaining about src/gluonts/dataset/artificial/recipe.py

@szha
Copy link
Member

szha commented Sep 16, 2019

Job PR-286/5 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-286/5/index.html

@szha
Copy link
Member

szha commented Sep 16, 2019

Job PR-286/6 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-286/6/index.html

@jgasthaus jgasthaus merged commit 4479857 into awslabs:master Sep 16, 2019
@jgasthaus jgasthaus deleted the synthetic branch September 16, 2019 17:02
dcmaddix pushed a commit that referenced this pull request Sep 16, 2019
…m key as changed in the synthetic dataset classes in PR #286
@dcmaddix dcmaddix mentioned this pull request Sep 16, 2019
dcmaddix pushed a commit that referenced this pull request Sep 16, 2019
dcmaddix added a commit that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants