Docs: fix missing values use-case in tutorial for PandasDataset
#2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reindexing of the grouped dataframes is being performed on the original dataframe. It should be preformed on the dataframe where rows were removed, df_missing_val.
|
Hello @cneely33 , thanks for this PR. Your observations seem to be correct. To go ahead with your PR, could you please as well update the frequency as you have pointed out, i.e. from "1D" to "1H"? Thanks! |
melopeo
requested changes
Jul 14, 2023
Correcting error by changing frequency of new dataframe index from Daily to Hourly
|
Thanks @cneely33! I think we can merge this, and see about style check failures separately |
lostella
changed the title
PandasDataset docs
lostella
changed the title
PandasDataset docsPandasDataset docs
lostella
added
documentation
lostella
changed the title
PandasDataset docsPandasDataset
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Aug 7, 2023
Merged
lostella
added a commit
that referenced
this pull request
Aug 7, 2023
* Fix JsonLinesFile slicing. (#2925) * Zebras: Fix index handling of SplitFrame.resize. (#2938) * Docs: fix missing values use-case in `PandasDataset` docs (#2941) * Ignore F403 errors in preludes. (#2948) * Fix: prevent accumulation of `SelectFields` in `PyTorchPredictor` (#2951) * Prevent redundant accumulation of fields * update fix --------- Co-authored-by: Cameronwood611 <cwood611@uab.edu> Co-authored-by: Lorenzo Stella <stellalo@amazon.com> * [Docs] fix link to NPTS implementation (#2953) * Revert "Fix JsonLinesFile slicing. (#2925)" This reverts commit fa7f9a0. --------- Co-authored-by: Jasper <schjaspe@amazon.de> Co-authored-by: cneely33 <cneely33@gmail.com> Co-authored-by: cameronwood611 <cameron.wood611@gmail.com> Co-authored-by: Cameronwood611 <cwood611@uab.edu>
lostella
removed
the
pending v0.13.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reindexing of the grouped dataframes is being performed on the original dataframe. It should be preformed on the dataframe where rows were removed, df_missing_val.
The freq of pd.date_range on line 127 is also set to "1D" instead of "1H" as in the original dataframe.
*Description of changes: Update pandasdataframes.md.template