Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch] Return a model even if callback has no best model path #2952

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[torch] Return a model even if callback has no best model path #2952

merged 1 commit into from
Jul 31, 2023

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Jul 28, 2023

makes the train more robust especially if one passes max_epoch=0 or num_batches_per_epoch=0 to the estimators

@lostella
Copy link
Contributor

@kashif are max_epochs==0 and num_batches_per_epoch==0 the only occasions in which the path would be empty?

@lostella lostella changed the title [torch] return a model even if lightning callbacks is empty [torch] Return a model even if callback has no best model path Jul 31, 2023
@lostella lostella merged commit 27182a0 into awslabs:dev Jul 31, 2023
18 of 21 checks passed
@lostella lostella added the torch This concerns the PyTorch side of GluonTS label Jul 31, 2023
@kashif kashif deleted the robust-fit branch July 31, 2023 12:57
@kashif
Copy link
Contributor Author

kashif commented Jul 31, 2023

thanks!

@kashif
Copy link
Contributor Author

kashif commented Jul 31, 2023

yes those were the only 2 and perhaps if batch_size=0...

@lostella lostella added the pending v0.13.x backport This contains a fix to be backported to the v0.13.x branch label Oct 16, 2023
lostella pushed a commit to lostella/gluonts that referenced this pull request Oct 16, 2023
@kashif @lostella
[torch] Return a model even if callback has no best model path (awsla…
08b59bc 
…bs#2952)
@lostella lostella mentioned this pull request Oct 16, 2023
Merged
lostella added a commit that referenced this pull request Oct 16, 2023
@lostella @kashif @shchur
Backports v0.13.6 (#3016)
e6f5663 
* [torch] Return a model even if callback has no best model path (#2952)

* Move from `pytorch_lightning` to `lightning` (#3013)

---------

Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Co-authored-by: Oleksandr Shchur <shchuro@amazon.com>
@lostella lostella removed the pending v0.13.x backport This contains a fix to be backported to the v0.13.x branch label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostella lostella lostella approved these changes

Assignees
No one assigned
Labels
torch This concerns the PyTorch side of GluonTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashif @lostella