Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LookupValues from Wavenet to gluonts.torch.modules #2974

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

abdulfatir
Copy link
Contributor

Issue #, if available:

Description of changes: This PR moves the LoopupValues module from local Wavenet directory to global torch modules.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@abdulfatir abdulfatir changed the title Move LookupValues from Wavenet to global torch modules Move LookupValues from Wavenet to gluonts.torch.modules Aug 22, 2023
Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Test failures unrelated, we can override

@lostella lostella added BREAKING This is a breaking change (one of pr required labels) enhancement New feature or request and removed BREAKING This is a breaking change (one of pr required labels) labels Aug 22, 2023
@abdulfatir abdulfatir merged commit 3594322 into awslabs:dev Aug 22, 2023
19 of 21 checks passed
@lostella lostella added the torch This concerns the PyTorch side of GluonTS label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request torch This concerns the PyTorch side of GluonTS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants