Fix ArrowDecoder.decode to return instead of yield #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulfatir
reviewed
Aug 22, 2023
|
@abdulfatir in fact, this was the previous behaviour of the |
lostella
force-pushed
the
fix-arrow-decode
branch
from
40dd317
to
e073d83
Compare
abdulfatir
approved these changes
Aug 22, 2023
lostella
added
the
pending v0.13.x backport
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Aug 24, 2023
Merged
lostella
added a commit
that referenced
this pull request
Aug 25, 2023
* Turn `type` comparison into `isinstance` (#2958) * Clean up RepresentablePredictor (#2967) * Fix: use `isinstance` instead of type comparison (#2973) * fix type comparison --------- Co-authored-by: Pedro Eduardo Mercado Lopez <pedroml@amazon.com> * Fix ArrowDecoder.decode to return instead of yield (#2976) * Unpin pyarrow version (#2977) * Fix Cython version in XGBoost tests (#2966) * black --------- Co-authored-by: Pedro Mercado <34275963+melopeo@users.noreply.github.com> Co-authored-by: Pedro Eduardo Mercado Lopez <pedroml@amazon.com>
lostella
removed
the
pending v0.13.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ArrowDecoder.decodeused toyield fromsomething, effectively returning a generator. This meant for example thatArrowFile.__getitem__also returns a generator when given an integer index, see here. This PR fixes it to make them return a record from the file instead.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup