Fix WaveNet inputs #3022
Merged
Fix WaveNet inputs #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
pending v0.14.x backport
|
@shchur I'm wondering whether this test case should have caught the issue? |
|
@lostella Actually, I think that the model only breaks for |
lostella
approved these changes
Oct 20, 2023
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Oct 27, 2023
lostella
added a commit
that referenced
this pull request
Oct 27, 2023
* Fix WaveNet inputs (#3022) * Fix version range for lightning (#3023) * Allow VCS install using GLUONTS_FALLBACK_VERSION (#3028) * Make `mypy` checks opt-out instead of opt-in, fix several type issues (#3027) Co-authored-by: Oleksandr Shchur <shchuro@amazon.com> * No API docs for nursery. (#3030) * Fix: #3030. (#3031) * Add support for Pydantic v1 and v2. (#3026) --------- Co-authored-by: Oleksandr Shchur <shchuro@amazon.com> Co-authored-by: ddelange <14880945+ddelange@users.noreply.github.com> Co-authored-by: Jasper <schjaspe@amazon.de>
lostella
added
models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3021
Description of changes:
feat_static_realto the WaveNet modelnum_featurescomputation in WaveNet model to account for the observed value indicatorBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup