Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch: Remove double caching of dataset. #3061

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

jaheba
Copy link
Contributor

@jaheba jaheba commented Nov 24, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports to be removed, otherwise looks good 👍

Could this be backported as well?

@jaheba
Copy link
Contributor Author

jaheba commented Nov 24, 2023

I guess we should also backport this. No need to keep the dataset in memory twice

@lostella lostella added the pending v0.14.x backport This contains a fix to be backported to the v0.14.x branch label Nov 24, 2023
@lostella lostella enabled auto-merge (squash) November 26, 2023 10:48
@lostella lostella merged commit 7dbe5e6 into awslabs:dev Nov 26, 2023
19 checks passed
@jaheba jaheba deleted the torch-double-cached branch November 27, 2023 07:40
lostella pushed a commit to lostella/gluonts that referenced this pull request Nov 27, 2023
@lostella lostella mentioned this pull request Nov 27, 2023
lostella added a commit that referenced this pull request Nov 27, 2023
* Fix `iterable.Cached`. (#3060)

* Torch: Remove double caching of dataset. (#3061)

---------

Co-authored-by: Jasper <schjaspe@amazon.de>
@lostella lostella removed the pending v0.14.x backport This contains a fix to be backported to the v0.14.x branch label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants