Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cpflows dependencies in test workflows, fix numpy 2 incompatibilities. #3227

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Oct 17, 2024

Issue #, if available: CPFlows is a dependency for gluonts.torch.model.mqf2, but it comes with dependencies constraints that hold us back. So for example, not the latest numpy version was used in CI tests.

Description of changes: Ignore dependencies of CPFlows in GitHub workflows. Fix incompatibilities with the latest numpy.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella added CI This item concerns continuous integration dependency This involves dependencies issues labels Oct 17, 2024
@lostella
Copy link
Contributor Author

lostella commented Oct 17, 2024

Latest numpy being installed https://github.com/awslabs/gluonts/actions/runs/11381924102/job/31664375765?pr=3227#step:4:298

Need to look into the failing tests

@lostella lostella changed the title Ignore cpflows dependencies in test workflows Ignore cpflows dependencies in test workflows, fix numpy 2 incompatibilities. Oct 17, 2024
@lostella lostella added the tests This item concerns improving tests label Oct 17, 2024
@lostella lostella requested a review from shchur October 17, 2024 09:49
Copy link
Contributor

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lostella lostella merged commit 3d05d46 into awslabs:dev Oct 17, 2024
20 checks passed
@lostella lostella deleted the ignore-cpflows-deps branch October 17, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI This item concerns continuous integration dependency This involves dependencies issues tests This item concerns improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants