Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Assure Learning Rate Scheduler does not increase the learning rate #359

Merged
merged 2 commits into from
Oct 1, 2019

Conversation

ivallesp
Copy link
Contributor

@ivallesp ivallesp commented Oct 1, 2019

When the base learning rate is smaller than the minimum learning rate, the following operation is applied:

max(min_lr, factor*base_lr)

This effectively increases the learning rate once the patience epochs without improvement are reached.

Description of changes:

I included an assert statement to break in case min_lr > base_lr

@szha
Copy link
Member

szha commented Oct 1, 2019

Job PR-359/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-359/1/index.html

@szha
Copy link
Member

szha commented Oct 1, 2019

Job PR-359/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-359/2/index.html

@codecov-io
Copy link

Codecov Report

Merging #359 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #359      +/-   ##
=========================================
+ Coverage   80.09%   80.1%   +<.01%     
=========================================
  Files         146     146              
  Lines        8356    8357       +1     
=========================================
+ Hits         6693    6694       +1     
  Misses       1663    1663
Impacted Files Coverage Δ
src/gluonts/trainer/learning_rate_scheduler.py 100% <100%> (ø) ⬆️

@lostella
Copy link
Contributor

lostella commented Oct 1, 2019

@ivallesp good catch, thanks for the PR!

@lostella lostella merged commit 5d141f6 into awslabs:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants