Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of network parameters #386

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix printing of network parameters #386

merged 1 commit into from
Oct 11, 2019

Conversation

timoschowski
Copy link
Contributor

Issue #, if available:
#310
Description of changes:
This fixes the number of parameters. I need some education where I should best add a test for this or if I should indeed add a test for this.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link
Member

szha commented Oct 11, 2019

Job PR-386/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-386/1/index.html

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #386 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   80.01%   80.01%   +<.01%     
==========================================
  Files         146      146              
  Lines        8397     8398       +1     
==========================================
+ Hits         6719     6720       +1     
  Misses       1678     1678
Impacted Files Coverage Δ
src/gluonts/trainer/_base.py 93.33% <100%> (+0.05%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants