Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more references in README for related scientific papers #389

Merged
merged 8 commits into from
Oct 16, 2019
Merged

add more references in README for related scientific papers #389

merged 8 commits into from
Oct 16, 2019

Conversation

timoschowski
Copy link
Contributor

Description of changes:

This adds a bibliography of related work to the README.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link
Member

szha commented Oct 13, 2019

Job PR-389/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-389/1/index.html

@codecov-io
Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files         146      146           
  Lines        8402     8402           
=======================================
  Hits         6724     6724           
  Misses       1678     1678

@jaheba
Copy link
Contributor

jaheba commented Oct 14, 2019

I think we shouldn't make the README too long. Maybe we can add a "science" folder or file where we can add links to the paper. Maybe we can even add the abstracts to it.

Alternatively, we could add the references where they relate to. For example, add a README to the deep-factor model which adds the reference to the paper.

@timoschowski
Copy link
Contributor Author

I think we shouldn't make the README too long. Maybe we can add a "science" folder or file where we can add links to the paper. Maybe we can even add the abstracts to it.

Alternatively, we could add the references where they relate to. For example, add a README to the deep-factor model which adds the reference to the paper.

How about having a "Further Material" section in the README and then link to this file?

@jaheba
Copy link
Contributor

jaheba commented Oct 14, 2019

Good idea!

jaheba
jaheba previously approved these changes Oct 14, 2019
Copy link
Contributor

@jaheba jaheba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

REFERENCES.md Outdated
GluonTS. They are grouped according to topic and ordered
chronographically.

### Methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there a H2 heading in-between?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Added this.

@szha
Copy link
Member

szha commented Oct 14, 2019

Job PR-389/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-389/2/index.html

```
A scalable state space model.
```
@inproceedings{seeger2016bayesian,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not available, can you remove it from the list?

It would be really nice to have a link to the source code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about I leave the paper in here, but with a remark that this isn't part of GluonTS currently?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to add pointers only to papers that are in Gluon-ts otherwise it is arguable why putting this reference rather than another one but I let you take the final decision ;)

@szha
Copy link
Member

szha commented Oct 14, 2019

Job PR-389/3 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-389/3/index.html

@szha
Copy link
Member

szha commented Oct 14, 2019

Job PR-389/4 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-389/4/index.html

@szha
Copy link
Member

szha commented Oct 15, 2019

Job PR-389/5 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-389/5/index.html

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the REFERENCES.md could use direct links to the publications web pages, for each entry. Otherwise this fails at being a “further reading” section I believe

REFERENCES.md Outdated Show resolved Hide resolved
REFERENCES.md Show resolved Hide resolved
@timoschowski
Copy link
Contributor Author

I think the REFERENCES.md could use direct links to the publications web pages, for each entry. Otherwise this fails at being a “further reading” section I believe

True. I'll add the links.

@szha
Copy link
Member

szha commented Oct 16, 2019

Job PR-389/7 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-389/7/index.html

in particular slides, linked from below.

### KDD 2019
[paper](https://dl.acm.org/citation.cfm?id=3332289)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[paper](https://dl.acm.org/citation.cfm?id=3332289)
[Paper](https://dl.acm.org/citation.cfm?id=3332289) and

}
```
### SIGMOD 2019
[paper](https://dl.acm.org/citation.cfm?id=3314033&dl=ACM&coll=DL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[paper](https://dl.acm.org/citation.cfm?id=3314033&dl=ACM&coll=DL)
[Paper](https://dl.acm.org/citation.cfm?id=3314033&dl=ACM&coll=DL) and

}
```
### VLDB 2018
[paper](http://www.vldb.org/pvldb/vol11/p2102-faloutsos.pdf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[paper](http://www.vldb.org/pvldb/vol11/p2102-faloutsos.pdf)
[Paper](http://www.vldb.org/pvldb/vol11/p2102-faloutsos.pdf) and

}
```
A two-part article introducing deep learning for forecasting.
[part 2](https://foresight.forecasters.org/product/foresight-issue-52/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[part 2](https://foresight.forecasters.org/product/foresight-issue-52/)
[Part 2](https://foresight.forecasters.org/product/foresight-issue-52/) and

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final changes required and then this can go!

@szha
Copy link
Member

szha commented Oct 16, 2019

Job PR-389/8 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-389/8/index.html

@lostella lostella merged commit 3558cdb into awslabs:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants