Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma distribution implemented. #502

Merged
merged 5 commits into from
Dec 10, 2019

Conversation

AaronSpieler
Copy link
Contributor

This is related to Issue #467.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Dec 8, 2019

Codecov Report

Merging #502 into master will increase coverage by 0.05%.
The diff coverage is 92.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   83.78%   83.83%   +0.05%     
==========================================
  Files         159      160       +1     
  Lines        9458     9513      +55     
==========================================
+ Hits         7924     7975      +51     
- Misses       1534     1538       +4
Impacted Files Coverage Δ
src/gluonts/distribution/__init__.py 95.65% <100%> (+0.19%) ⬆️
src/gluonts/distribution/gamma.py 92.59% <92.59%> (ø)

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good overall, see some minor comments inline.

src/gluonts/distribution/gamma.py Outdated Show resolved Hide resolved
Co-Authored-By: Lorenzo Stella <lorenzostella@gmail.com>
Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concern with the unguarded softplus in the GammaOutput class, see my inline comment.

src/gluonts/distribution/gamma.py Outdated Show resolved Hide resolved
@lostella
Copy link
Contributor

Nice, thanks! One thing you could do, just to see it working, is to try out some model using GammaOutput. For example, you can take the quick start example from the README and make sure that runs through

@AaronSpieler AaronSpieler merged commit 08ab434 into awslabs:master Dec 10, 2019
@AaronSpieler AaronSpieler deleted the gamma_distributions branch December 10, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants