Fix instance splitter issue with short time series #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
changed the title
|
Polished the code, updated the tests, added test cases with |
lostella
commented
Dec 17, 2019
Comment on lines
+224
to
+230
| assert len(out) == max( | ||
| 0, | ||
| len(target) | ||
| - pred_length | ||
| + 1 | ||
| - (0 if pick_incomplete else train_length), | ||
| ) |
There was a problem hiding this comment.
Sometimes I really don't understand black
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
===========================================
+ Coverage 43.29% 83.13% +39.83%
===========================================
Files 177 177
Lines 9857 9857
===========================================
+ Hits 4268 8195 +3927
+ Misses 5589 1662 -3927
|
vafl
reviewed
Dec 17, 2019
vafl
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Some checks are added in the
InstanceSplitterclass for the case wherepick_incomplete=False. This would otherwise cause problems downstream, when the sampler would to sample from an interval that has inverted bounds.Further checks and typing cleanup are added.
Opening for feedback, trying to include a small test for this.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.