Fix item_id field in provided datasets #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
- Coverage 83.27% 83.26% -0.02%
==========================================
Files 178 178
Lines 9958 9960 +2
==========================================
Hits 8293 8293
- Misses 1665 1667 +2
|
AaronSpieler
approved these changes
Jan 21, 2020
mbohlkeschneider
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #291
Description of changes: This adds an
"item_id"field in the provided dataset recipes. Getting the datases withregenerate=Trueshould then fix #291. I set the"item_id"field to be the same incremental integer as the"cat"field, but we could decide of using something slightly different there for clarity (like the"item<N>"string or something like that).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.