Add pow operation to synthetic data generation #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
commented
Jan 29, 2020
Comment on lines
-168
to
+177
| return LiftedMul(self, other, operator.mul) | ||
| return LiftedMul(self, other) | ||
|
|
||
| def __rmul__(self, other): | ||
| return LiftedMul(other, self, operator.mul) | ||
| return LiftedMul(other, self) | ||
|
|
||
| def __truediv__(self, other): | ||
| return LiftedTruediv(self, other, operator.truediv) | ||
| return LiftedTruediv(self, other) | ||
|
|
||
| def __rtruediv__(self, other): | ||
| return LiftedTruediv(other, self, operator.truediv) | ||
| return LiftedTruediv(other, self) |
There was a problem hiding this comment.
As far as I understand, the third argument provided here is hardcoded in the specific LiftedBinaryOp subclass. Apparently calling the constructor with three arguments would directly invoke the parents' constructor? Not sure...
There was a problem hiding this comment.
Good catch, i would guess any of these calls would just fail.
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 83.25% 83.25% -0.01%
==========================================
Files 178 178
Lines 9957 9959 +2
==========================================
+ Hits 8290 8291 +1
- Misses 1667 1668 +1 |
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 83.25% 83.53% +0.28%
==========================================
Files 178 182 +4
Lines 9959 10317 +358
==========================================
+ Hits 8291 8618 +327
- Misses 1668 1699 +31
|
jgasthaus
approved these changes
Jan 29, 2020
Comment on lines
-168
to
+177
| return LiftedMul(self, other, operator.mul) | ||
| return LiftedMul(self, other) | ||
|
|
||
| def __rmul__(self, other): | ||
| return LiftedMul(other, self, operator.mul) | ||
| return LiftedMul(other, self) | ||
|
|
||
| def __truediv__(self, other): | ||
| return LiftedTruediv(self, other, operator.truediv) | ||
| return LiftedTruediv(self, other) | ||
|
|
||
| def __rtruediv__(self, other): | ||
| return LiftedTruediv(other, self, operator.truediv) | ||
| return LiftedTruediv(other, self) |
There was a problem hiding this comment.
Good catch, i would guess any of these calls would just fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
powoperation to the synthetic data generation package. This is useful e.g. to generate uniformly log-scaled data.Also, some minor code cleanup.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.