Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for symbol block serialization issue #582

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

canerturkmen
Copy link
Contributor

Issue #, if available: #581

Description of changes:
Changes symbol block import/export helpers in support.util to persist input/output format information and tiptoes around some other mxnet quirks.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@canerturkmen canerturkmen changed the title Fix for symbol block serialization issue (#581) Fix for symbol block serialization issue Jan 30, 2020
Copy link
Contributor

@vafl vafl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! That's going deep into the mxnet plumbing.
Do you know if there is an mxnet issue for this problem?

@canerturkmen canerturkmen merged commit 2889be4 into awslabs:master Jan 30, 2020
@canerturkmen canerturkmen deleted the fix_symb_block_serde branch January 30, 2020 20:01
@canerturkmen
Copy link
Contributor Author

Do you know if there is an mxnet issue for this problem?

There is now, apache/mxnet#17488.

@vafl
Copy link
Contributor

vafl commented Jan 30, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants