Fixed minor bugs in GluonTSFramework. #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 181 181
Lines 10326 10326
=======================================
Hits 8645 8645
Misses 1681 1681
|
AaronSpieler
changed the title
|
Is that base_job_name handling the same as in other frameworks? |
Actually it does not seem to be that way, job_name will be the actual job name. However, I find that counter intuitive, since one already defines a base_job_name. |
|
Then let’s not do that as well. The idea behind the base job is to specify the job name just once and then spawn of jobs from that. |
jaheba
previously requested changes
Jan 31, 2020
ok |
lostella
previously approved these changes
Feb 6, 2020
lostella
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
- Coverage 83.73% 83.72% -0.02%
==========================================
Files 181 181
Lines 10324 10326 +2
==========================================
Hits 8645 8645
- Misses 1679 1681 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixed bug regarding wait parameter in train function of GluonTSFramework.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.