Change causal conv1d default activation to match the doc #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
requested review from
jgasthaus and
lovvge
and removed request for
lostella
|
@jgasthaus @lovvge do you know what the intended default is for this option? Either the default value is changed to match the docstring (as per the proposed fix), or the other way around. |
Changing the default to None (as the doc states) makes sense to me. All callers do explicitly set it to "relu" when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Default activation used in CausalConv1d doesn't match the code. Changing it to
Nonefrom"relu".By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.