Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in RForecastPredictor #798

Merged
merged 2 commits into from
Apr 30, 2020
Merged

fix in RForecastPredictor #798

merged 2 commits into from
Apr 30, 2020

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Apr 30, 2020

fix pandas Timestamp

Issue #, if available:

Description of changes:

the pandas API has changed and this is the preferred way as far as i am aware.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fix pandas Timestamp
@jaheba
Copy link
Contributor

jaheba commented Apr 30, 2020

There is forecast_start in gluonts.support.pandas. Would that work?

@kashif
Copy link
Contributor Author

kashif commented Apr 30, 2020

@jaheba checking...

Copy link
Contributor

@jaheba jaheba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaheba jaheba merged commit 53120d4 into awslabs:master Apr 30, 2020
@kashif kashif deleted the pandas-fix branch April 30, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants