add SampleForecast and Predictor objects for TPPs #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
reviewed
May 20, 2020
lostella
previously approved these changes
May 20, 2020
canerturkmen
force-pushed
the
tpp-predictor
branch
from
7de614a
to
ed47dba
Compare
lostella
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Related to #294
Description of changes: Adds
SampleForecast,ForecastGeneratorandGluonPredictorobjects that will be shared among temporal point process models. TPPs need unique subclasses of each primarily since forecasts need to be ragged tensors (variable valid length) and predictors must be aware of unique inference data loaders / forecast generators.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.