refactor imputation transformation #907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring of
AddObservedValueIndicator
transformation.Removed unnecessary fields:
dummy_value
: This is imputation-method-dependent and should not be an argument of the transformation. Instead the transformation should take as input the imputation method with this field set already.convert_nans
: This is unnecessary since we can just use None as imputation method.With the above change we have control IF we want to do imputation or not in the transformation by including a hyperparameter in the estimator (setting it to the appropriate imputation method or to None). This gives the flexibility to select from a model-based imputation method (e.g. if set to None use a sample from the predictive distribution since the imputation from the transformation is disabled) or from a transformation based imputation (e.g. a dummy value).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.