Shape squeeze edge case bug fix #911
Conversation
No, I am adding a test. |
| @@ -87,6 +87,8 @@ class MeanValueImputation(MissingValueImputation): | |||
| """ | |||
|
|
|||
| def __call__(self, values: np.ndarray) -> np.ndarray: | |||
| if len(values) == 1: | |||
| return DummyValueImputation()(values) | |||
There was a problem hiding this comment.
Would it make sense to pass a user specified dummy_value when constructing the DummyValueImputation object here? Essentially, all these classes would allow specifying the dummy_value, to be used in extreme cases.
But maybe not urgent and can be addressed later.
There was a problem hiding this comment.
Yeah, so the DummyValueImputation accepts a value that uses to impute. With the current implementation it uses the default. We can always add one more argument to all the imputation methods to override the default but maybe this is too much. If needed we can always include it easily.
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
=======================================
Coverage 86.04% 86.05%
=======================================
Files 195 195
Lines 11869 11877 +8
=======================================
+ Hits 10213 10221 +8
Misses 1656 1656
|
Fixes an edge case where we pass a single value and
np.squeezesuppresses all dimensions.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.