fix: fix time series data hook reactivity

awslabs · Nov 26, 2024 · 289c135 · 289c135
1 parent 7a3ecdc
commit 289c135
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/core/src/data-module/TimeSeriesDataModule.ts b/packages/core/src/data-module/TimeSeriesDataModule.ts
@@ -187,7 +187,9 @@ export class TimeSeriesDataModule<Query extends DataStreamQuery> {
      */
 
     const unsubscribe = () => {
-      this.unsubscribe(subscriptionId);
+      if (this.subscriptions.getSubscription(subscriptionId)) {
+        this.unsubscribe(subscriptionId);
+      }
     };
 
     const update = (subscriptionUpdate: SubscriptionUpdate<Query>) =>

diff --git a/packages/react-components/src/hooks/useTimeSeriesData/useTimeSeriesData.ts b/packages/react-components/src/hooks/useTimeSeriesData/useTimeSeriesData.ts
@@ -108,6 +108,15 @@ export const useTimeSeriesData = ({
   const queriesString = JSON.stringify(scrubbedQueries);
 
   useEffect(() => {
+    /**
+     * Reset datastreams whenever the query changes so that
+     * old datastreams are cleared away. This is important if
+     * the new query does not end up calling next for some
+     * reason. In that case, the datastreams state would still
+     * represent the previous queries data.
+     */
+    setDataStreams([]);
+
     const id = uuid();
     providerIdRef.current = id;
     const provider = ProviderStore.set(