fix: tooltip styled component issue is fixed #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chandru-HM
force-pushed
the
fix/tooltip-styled-component-issue-fix
branch
from
7046c30
to
23ade09
Compare
|
LGTM |
corteggiano
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix an issue (#2785) with a styled component inside another component.
Resolve this by creating new StyledComponents outside of the render method and function component.
Verifying Changes
before:
https://github.com/awslabs/iot-app-kit/assets/142866907/50be5d0e-4f33-4174-803e-f2f8e3e11329
after:
https://github.com/awslabs/iot-app-kit/assets/142866907/2f887b87-4c1e-4547-a6ed-bab73955d65a
Legal
This project is available under the Apache 2.0 License.