fix(react-components): allow vertical legend reszing when title present on widget #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When there was a title present, legend resizing vertically would automatically set the height of the legend to the maximum size and allow no user interaction. This was because we were setting the height to be the adjustedChartHeight value, that considers the title being present. However, in the hook where we get the chartHeight/Width the chart height is already factored in. This was making the chart default to something too large, hence always being stuck at the max-constraint.
Simple fix: just use the chartHeight given by our useResizableEChart hook.
Verifying Changes
Screen.Recording.2024-11-20.at.2.34.39.PM.mov
Legal
This project is available under the Apache 2.0 License.