chore: update stale packages #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracy-french
force-pushed
the
force-update-packages
branch
14 times, most recently
from
45c0e26 to
f6d986f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tracy-french
force-pushed
the
force-update-packages
branch
8 times, most recently
from
31a50c6 to
ea05f43
Compare
tracy-french
force-pushed
the
force-update-packages
branch
from
ea05f43 to
4ba6430
Compare
tracy-french
changed the title
hwandersman
reviewed
Nov 25, 2024
| "test:ui:update": "npm run playwright -- npx playwright test --update-snapshots", | ||
| "test:ui:dev": "npx playwright test --ui", | ||
| "storybook": "npm run copy-assets:es && start-storybook -h 0.0.0.0 -p 7006", | ||
| "test:ui:update2": "npm run playwright -- npx playwright test --update-snapshots", |
There was a problem hiding this comment.
nit: did you mean to change the command name here?
There was a problem hiding this comment.
Oof. That was a mistake. I'll fix it!
|
Anything to add to the package READMEs about new commands, installation, storybook setup, env vars? |
hwandersman
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
All over the code base, the wrong versions of dependencies are being used. This change fixes this issue, allowing the dependency versions listed in package.json files to be used correctly.
The issue was likely caused by improper installation of packages using npm workspaces. I plan on talking with the team how to install packages.
In the process of fixing this issue, which was primarily fixed by regenerating package-lock.json, the updates up many dependencies had to be handled, most notably storybook. There was a version mismatch between doc-site (storybook v7) and other packages (storybook v6) and only the lock file was holding the issue at bay. Once unlocked, transitive dependencies experienced versioning conflicts.
In handling the storybook issue, I figured we might as well upgrade all the way to storybook 8 with vite. Hope you enjoy the dev experience!
Overall, as a result of this change, we should see:
Legal
This project is available under the Apache 2.0 License.