Skip to content

Commit

Permalink
Disable minio for s3 related deployments (#541)
Browse files Browse the repository at this point in the history
**Which issue is resolved by this Pull Request:**
Resolves # #508

**Description of your changes:**
- remove minio-pvc
- remove minio deployment
- remove minio-service

**Testing:**
- [ ] Unit tests pass
- [x] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed
- configure s3-only deployment and make sure objects are presented in s3
buckets after pipeline run.
  • Loading branch information
jsitu777 authored Jan 13, 2023
1 parent 951a5a7 commit 7bc2f9b
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 162 deletions.
1 change: 1 addition & 0 deletions awsconfigs/apps/pipeline/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ generatorOptions:
patchesStrategicMerge:
- ./rds/disable-mysql-pv-claim.yaml
- ./rds/disable-default-secret.yaml
- ./s3/disable-minio-server-resources.yaml
- ./s3/deployment_patch.yaml
- ./s3/disable-default-secret.yaml
- ./s3/aws-configuration-patch.yaml
Expand Down
20 changes: 20 additions & 0 deletions awsconfigs/apps/pipeline/s3/disable-minio-server-resources.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
$patch: delete
apiVersion: apps/v1
kind: Deployment
metadata:
name: minio
namespace: kubeflow
---
$patch: delete
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: minio-pvc
namespace: kubeflow
---
$patch: delete
apiVersion: v1
kind: Service
metadata:
name: minio-service
namespace: kubeflow
1 change: 1 addition & 0 deletions awsconfigs/apps/pipeline/s3/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ configMapGenerator:
generatorOptions:
disableNameSuffixHash: true
patchesStrategicMerge:
- disable-minio-server-resources.yaml
- deployment_patch.yaml
- disable-default-secret.yaml
- aws-configuration-patch.yaml
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 7bc2f9b

Please sign in to comment.