Skip to content

Commit

Permalink
Fix artifact/visual for S3 in terraform (#485)
Browse files Browse the repository at this point in the history
**Description of your changes:**
Fix artifact/visual for S3 in terraform

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
mbaijal authored Oct 14, 2022
1 parent 7ddc3bc commit a7e2ce1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ module "filter_kfp_set_values" {
set_values = {
"rds.dbHost" = try(module.rds[0].rds_endpoint, null),
"s3.bucketName" = try(module.s3[0].s3_bucket_name ,null),
"s3.minioServiceRegion" = try(var.minio_service_region, var.addon_context.aws_region_name)
"s3.minioServiceRegion" = coalesce(var.minio_service_region, var.addon_context.aws_region_name)
"rds.mlmdDb" = var.mlmdb_name,
"s3.minioServiceHost" = var.minio_service_host
}
Expand Down
2 changes: 1 addition & 1 deletion deployments/rds-s3/terraform/rds-s3-components/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ module "filter_kfp_set_values" {
set_values = {
"rds.dbHost" = try(module.rds[0].rds_endpoint, null),
"s3.bucketName" = try(module.s3[0].s3_bucket_name ,null),
"s3.minioServiceRegion" = try(var.minio_service_region, var.addon_context.aws_region_name)
"s3.minioServiceRegion" = coalesce(var.minio_service_region, var.addon_context.aws_region_name)
"rds.mlmdDb" = var.mlmdb_name,
"s3.minioServiceHost" = var.minio_service_host
}
Expand Down

0 comments on commit a7e2ce1

Please sign in to comment.