Availability w.r.t secrets manager integration #83
Assignees
Labels
Comments
surajkota
added
enhancement
surajkota
changed the title
surajkota
added a commit
that referenced
this issue
Feb 15, 2022
**Which issue is resolved by this Pull Request:** Resolves #76, #86 and partially #83 (disables istio sidecar injection) **Description of your changes:** - Created main repo README. Open to suggestions for improving content on this - Made changes to README under docs/deployment - Added documentation and kustomization for vanilla deployment under docs/deployment/vanilla and made DLC based jupyter notebooks as default - Moved storage options under add-ons to clarify they can be used with any deployment - Disabled istio sidecar injection for secrets mount pod (ref: #83) - Fix for #86 - Refractored components, overlays, readmes and tests related to aws modified components according to the following directory structure: ``` ├── awsconfigs │ ├── apps │ │ ├── jupyter-web-app │ │ ├── katib-external-db-with-kubeflow │ │ └── pipeline │ ├── common │ │ ├── aws-alb-ingress-controller │ │ ├── aws-istio-envoy-filter │ │ ├── aws-secrets-manager │ │ └── istio-ingress │ └── infra_configs ├── docs │ └── deployment │ ├── add-ons │ ├── cognito │ ├── cognito-rds-s3 │ ├── rds-s3 │ └── vanilla ├── tests │ └── e2e │ ├── __pycache__ │ ├── fixtures │ ├── resources │ ├── tests │ └── utils ``` - Added issue and PR templates - Added assertion for missing args in rds test **Testing:** Tested with **Kubeflow-v1.4.1** - [x] e2e tests: cognito, efs, fsx, sanity - [x] WIP: RDS-S3 e2e test is failing with #69 (comment) - [x] Add code in e2e tests to clone upstream **Pending** - Add unit tests - Add canary scripts
aicadium-bot-app bot
added a commit
to aicadium-archive/kubeflow-manifests
that referenced
this issue
Mar 13, 2023
**Which issue is resolved by this Pull Request:** Resolves awslabs#76, awslabs#86 and partially awslabs#83 (disables istio sidecar injection) **Description of your changes:** - Created main repo README. Open to suggestions for improving content on this - Made changes to README under docs/deployment - Added documentation and kustomization for vanilla deployment under docs/deployment/vanilla and made DLC based jupyter notebooks as default - Moved storage options under add-ons to clarify they can be used with any deployment - Disabled istio sidecar injection for secrets mount pod (ref: awslabs#83) - Fix for awslabs#86 - Refractored components, overlays, readmes and tests related to aws modified components according to the following directory structure: ``` ├── awsconfigs │ ├── apps │ │ ├── jupyter-web-app │ │ ├── katib-external-db-with-kubeflow │ │ └── pipeline │ ├── common │ │ ├── aws-alb-ingress-controller │ │ ├── aws-istio-envoy-filter │ │ ├── aws-secrets-manager │ │ └── istio-ingress │ └── infra_configs ├── docs │ └── deployment │ ├── add-ons │ ├── cognito │ ├── cognito-rds-s3 │ ├── rds-s3 │ └── vanilla ├── tests │ └── e2e │ ├── __pycache__ │ ├── fixtures │ ├── resources │ ├── tests │ └── utils ``` - Added issue and PR templates - Added assertion for missing args in rds test **Testing:** Tested with **Kubeflow-v1.4.1** - [x] e2e tests: cognito, efs, fsx, sanity - [x] WIP: RDS-S3 e2e test is failing with awslabs#69 (comment) - [x] Add code in e2e tests to clone upstream **Pending** - Add unit tests - Add canary scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Secrets mount is modelled as a pod which is unreliable incase the node goes down or secrets needs to be rotated(although auto rotation is not supported)
The text was updated successfully, but these errors were encountered: