-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .editorconfig file #135
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Maksym Voitko <max.voitko@gmail.com>
Signed-off-by: Maksym Voitko <max.voitko@gmail.com>
@surajkota Could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks cool! Thanks for the contribution. Few questions
do IDEs (once plugin is installed) format code instead of devs having to run black and go fmt commands?
|
||
[*.{py,rst,ini}] | ||
indent_style = space | ||
indent_size = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 4 for py, go and go but 2 for yaml/json? could you please add links to any official styling guidelines you followed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For py it's pep-8.
For yaml and json, it's just a matter of taste. It seems more concise for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any updates? @surajkota
The IDE will do the formatting specified in the |
I have not got a chance to try this out. Basically need to make sure these setting match the existing formatting tools we use black for python and go fmt for go I think yaml is 2 spaces, not sure about md files but those should just reder properly on the website |
@surajkota any chance it could be merged? |
@akartsky can you check if the configuration matches the styling in repo by installing it? We dont want the configuration to change all the files unless they have not been formatted correctly |
Signed-off-by: Maksym Voitko max.voitko@gmail.com
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.