add cdk support for private subnets detection #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrkharse
approved these changes
Jul 18, 2022
|
@theofpa Thanks for the contribution. Is there a way to reproduce this? Did you use EKS blueprints to create the cluster? |
|
I've just used the |
surajkota
pushed a commit
to surajkota/kubeflow-manifests
that referenced
this pull request
Aug 6, 2022
surajkota
pushed a commit
to surajkota/kubeflow-manifests
that referenced
this pull request
Aug 6, 2022
surajkota
added a commit
that referenced
this pull request
Aug 6, 2022
* Set s3 endpoint in workflow-controller-configmap from pipeline-install-config (#291) * Added support for non-root EFS files ownership (#268) * Updated documentation about EFS permissions * Added gid & uid to auto efs script * Updated EFS CSI driver to v1.4.0 * feat/267 Updated documentation about EFS & added default value for uid & gid * Update kserve.md (#304) * update: Adding a missing preposition in cognito guide (#307) The preposition "to" was missing in cognito guide * add cdk support for private subnets detection (#295) Co-authored-by: rrrkharse <91350438+rrrkharse@users.noreply.github.com> Co-authored-by: Alexandre Brown <26939775+AlexandreBrown@users.noreply.github.com> Co-authored-by: Gitesh Shinde <gitesh.shinde907@gmail.com> Co-authored-by: Jobin <76947418+kjvjobin@users.noreply.github.com> Co-authored-by: Theofilos Papapanagiotou <theofilos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #277
Description of your changes:
CDK generated EKS clusters have a different tag than eksctl generated ones, so with this change we also cover that RDS will have a subnet group of the private subnets and not fail.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.