Re-enable mysql for s3-only pipelines deployment #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you specify how you tested these changes and also the reason for making this change - the first line of the description is truncated. |
|
It was a known miss from previous commit that @rrrkharse may be able to answer better. Since it's not deploying with RDS, the mysql pod needs to be up otherwise it creates issue in pipeline. |
jsitu777
changed the title
mbaijal
approved these changes
Aug 5, 2022
surajkota
pushed a commit
to surajkota/kubeflow-manifests
that referenced
this pull request
Sep 17, 2022
Co-authored-by: jsitu <jsitu@88665a43d1bb.ant.amazon.com>
surajkota
added a commit
that referenced
this pull request
Sep 17, 2022
**Description of your changes:** Cherry-pick bug fixes to 1.5 release * Fix for RDS-S3 test: https://github.com/awslabs/kubeflow-manifests/pull/341/files * Fix the S3 only deployment: #310 * Fix S3 bucket name substitution: #333 * Fix insecure connection to S3 - #244 **Testing:** - e2e tests WIP By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: jsitu777 <59303945+jsitu777@users.noreply.github.com> Co-authored-by: jsitu <jsitu@88665a43d1bb.ant.amazon.com> Co-authored-by: rrrkharse <91350438+rrrkharse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's not deploying with RDS, the mysql pod needs to be up otherwise it creates issue in pipeline.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.