Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Fixing incomplete changes from #266
Changes in #266 are not sufficient because KServe is using 2 different configmaps(
kserve-config
,inferenceservice-config
) to configure the gateway depending on the component. I am not certain why but here is what going on:When an inferenceservice(isvc) is created, there are multiple virtualservices (VS) created. There is one VS for the inferenceservice and for each component inside ivsc like predictor, transformer etc. The ingress specified in the
inferenceservice-config
is configuring gateway used by the Virtual Service of the inference service itself and the ingress specified inkserve-config
, is configuring the gateways used by the individual components inside the inferenceservice, e.g. predictor, transformer. E.g.Notice the difference in gateway used by sklearn-irisv2 and sklearn-irisv2-predictor-default-ingress
The patch in #266, I missed the inferenceservice-config (I thought I patched both configs but there was a bug). Following is the output with this PR:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.